Bug 250643

Summary: Compute the keyTimes index correctly for discrete (values) animations
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, webkit-bug-importer, zimmermann
Priority: P2 Keywords: BrowserCompat, InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-01-15 04:15:54 PST
Hi Team,

While going through Blink's commit, I came across following, which can be merged:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/be50d8baacafe25f3a96d22be3e9a96ab882df4a

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGAnimationElement.cpp#406

It will make us pass, last two failing test from WPT here:

https://wpt.fyi/results/svg/animations?label=master&label=experimental&aligned&view=subtest&q=animate-elem-

Just wanted to raise, so we can fix it.

Thanks!
Comment 1 Ahmad Saleem 2023-01-15 05:56:44 PST
*** Bug 79786 has been marked as a duplicate of this bug. ***
Comment 2 EWS 2023-01-15 17:39:30 PST
Committed 258939@main (580e9612e2c6): <https://commits.webkit.org/258939@main>

Reviewed commits have been landed. Closing PR #8670 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-15 17:40:18 PST
<rdar://problem/104283488>