Bug 250631
| Summary: | Clip the start position when performing SVG text queries | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=120451 | ||
Ahmad Saleem
Hi Team,
Another failing text from Blink's commit:
Test - https://jsfiddle.net/uyh48n62/show
^ Failing in Safari 16.2 while passing in Chrome Canary 111 and Firefox Nightly 110
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/55ceb3d896e75fbb5d3bb10e12b17b10d297bf27
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGTextQuery.cpp#147
Just wanted raise to fix this.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
So this one has pre-requisite bug 120451.
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/8664
The test still fail and need to add platform specific expectations (if we want to land without pre-requisite) on GTK and Windows.
I am closing my PR but it is something still we need to track and fix.
Radar WebKit Bug Importer
<rdar://problem/104518891>
Ahmad Saleem
NOTE - This got reverted because of potential SVG Text optimisation done in Blink but the test case is still interesting, so let's keep this bug open.
Ahmad Saleem
Updated Test Case from Blink: https://jsfiddle.net/xfb7mahe/show
Ahmad Saleem
NOTE - This bug get fixed with bug 261651.
Ahmad Saleem
I think this blink commit is not right fix since with other SVGTextQuery optimization, this is still not fixed. It is to account for 'RTL' content in SVG.
Could be 'unsigned' (which is not negative) and 'int' (negative) as well thing?
Ahmad Saleem
Firefox Nightly 121 and Chrome Canary 120 passes this: https://jsfiddle.net/xfb7mahe/show
Adding 'BrowserCompat'.