Summary: | cannot play flash videos , nsplugin error | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | schmirrwurst <schmirrwurst> | ||||||||
Component: | Plug-ins | Assignee: | Jocelyn Turcotte <jturcotte> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, jturcotte, kenneth | ||||||||
Priority: | P2 | Keywords: | Qt | ||||||||
Version: | 420+ | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
schmirrwurst
2009-04-05 11:56:58 PDT
Created attachment 40521 [details]
White plugin bug patch
This patch corrects the white plugin bug which happened some times.
What happened is that the out-of-process plugin was not able to create its window under our xembed container since the window did not exist yet in the X server.
Created attachment 40522 [details]
Unstable initialization+error message fix patch
This patch fix the other part of the bug, the error message and some instabilities with the plugin
The canberra-gtk-module error message is unrelated to the unexpected behavior. This is a ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/ia32-libs/+bug/369498 Comment on attachment 40522 [details]
Unstable initialization+error message fix patch
r+
Comment on attachment 40521 [details]
White plugin bug patch
Jocelyn is not a committer, so marking this cq+.
Comment on attachment 40522 [details]
Unstable initialization+error message fix patch
Jocelyn is not a committer, so marking this cq+.
Comment on attachment 40521 [details] White plugin bug patch Clearing flags on attachment: 40521 Committed r49053: <http://trac.webkit.org/changeset/49053> Comment on attachment 40522 [details] Unstable initialization+error message fix patch Clearing flags on attachment: 40522 Committed r49054: <http://trac.webkit.org/changeset/49054> All reviewed patches have been landed. Closing bug. I think that such a change would require a comment in the source code, like: // sync our XEmbed container window creation before sending the xid to plugins. QApplication::syncX(); This way we minimize the change that it will be removed by accident in the future. Created attachment 40867 [details] White plugin bug patch v2 Re-add the QApplication::syncX() line for plugin windows removed by r49169 (as Kenneth predicted). Also changed the location of the sync just after the creation instead of just before sending it to the plugin. This reduces the number of unnecessary XSync. I took the opportunity to add a comment in the code :) Correction patch re-added, reopening. (Necessary?) Comment on attachment 40867 [details]
White plugin bug patch v2
Comment on attachment 40867 [details] White plugin bug patch v2 Clearing flags on attachment: 40867 Committed r49300: <http://trac.webkit.org/changeset/49300> All reviewed patches have been landed. Closing bug. |