Summary: | destroying webview widget directly causes crash. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Su <james.su> | ||||||||
Component: | WebKitGTK | Assignee: | Xan Lopez <xan.lopez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Critical | CC: | jmalonzo | ||||||||
Priority: | P1 | Keywords: | Gtk | ||||||||
Version: | 420+ | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
James Su
2009-04-03 16:57:04 PDT
Created attachment 29252 [details]
Test pack, show and destroy early
This patch adds the test case to our destroy unit test.
Created attachment 29265 [details]
dispose-screen-changed.patch
This fixes the crasher.
Created attachment 29266 [details]
default-handler-screen-changed.patch
While I'm at it, avoid the weirdness of the view connecting to its own screen-changed signal.
Comment on attachment 29252 [details] Test pack, show and destroy early > diff --git a/WebKit/gtk/tests/testwebframe.c b/WebKit/gtk/tests/testwebframe.c > index e2da29c..2797fa0 100644 > --- a/WebKit/gtk/tests/testwebframe.c > +++ b/WebKit/gtk/tests/testwebframe.c > @@ -26,14 +26,22 @@ > static void test_webkit_web_frame_create_destroy(void) > { > WebKitWebView* webView; > - g_test_bug("21837"); > + GtkWidget *window; placement of '*' is inconsistent. Please make it consistent when landing. :) Comment on attachment 29266 [details]
default-handler-screen-changed.patch
Nice!
Comment on attachment 29252 [details]
Test pack, show and destroy early
Committed with revision 42591.
|