Bug 250273
| Summary: | Remove unnecessary repaint in SVGSVGElement::updateCurrentTranslate | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Taher <taher_ali> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across following (don't have any test case) but usually removing extra repaint is good thing.
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/18931319384cde07cb01909b6e2a43381d5bc1de
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGSVGElement.cpp#162
Just wanted to raise for discussion and if needed, we can also remove it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104261056>
Ahmad Saleem
https://github.com/WebKit/WebKit/blob/44fccba78690ca1160f1d8c8776103e8540a0bae/Source/WebCore/svg/SVGSVGElement.cpp#L165
^ Just to update correct reference.
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/34376
Taher
Pull request: https://github.com/WebKit/WebKit/pull/57820
EWS
Committed 306775@main (6c8b2eff6e17): <https://commits.webkit.org/306775@main>
Reviewed commits have been landed. Closing PR #57820 and removing active labels.