Bug 250080
| Summary: | _WKAuthenticatorAttestationResponse and _WKAuthenticatorResponse should retain/copy their instance variables | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kkinnunen, pascoe, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
_WKAuthenticatorAttestationResponse and _WKAuthenticatorResponse should retain their instance variables.
Currently they are storing NSObject types as the equivalent of __unsafe_unretained, and not copying @property objects with the `copy` attribute.
Found by clang static analyzer (as leaks, but only when using getter/setter methods, not via direct assignment).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103876775>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/8198
EWS
Committed 258471@main (fe1655421cc5): <https://commits.webkit.org/258471@main>
Reviewed commits have been landed. Closing PR #8198 and removing active labels.