Bug 24984
| Summary: | [Gtk] Webkit doesn't render some favicons | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Stéphane Marguet <stempubuntu> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | cyberskull, mrobinson, xan.lopez |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Stéphane Marguet
Tested with WebKitGtk+ 1.1.5, some icons .ico are not rendered properly.
Ironically Webkit favicon by example : http://webkit.org/favicon.ico
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
antistress
i can confirm that bug
see for instance http://commons.wikimedia.org/wiki/Accueil
Xan Lopez
1.1.5 does not exist yet, so I guess you mean 1.1.4 (or you come from the future). Also, the ico decoder implementation we use, the default one, is empty, so I'd be surprised if WebKitGTK+ managed to render any ico file at all. Have you actually found any that works?
Stéphane Marguet
Sorry about WebkitGtk+ 1.1.5, it's a mix between WebkitGtk 1.1.4 and Midori 0.1.5 :D
So I guess this bug is not a Webkit bug but a midori one (or another library).
I thought the ico decoding was done in Webkit.
Sorry again.
Xan Lopez
No, I meant that we don't really have any ico decoder that I know, so AFAIK we shouldn't really be able to render any ico file. It most definitely should be fixed in WebKitGTK+, not in Midori.
Trevor Downs
This has been an issue for a while on Mac OS X, in not just Safari but also Shiira. Does WebKit have no ico decoder on any platform, or does it use it's own on some?
Another example would be <http://drunkduck.com/>. The favicon works in Firefox, but not in any WebKit browser I have tested.
Alexey Proskuryakov
Please file a new bug about <http://drunkduck.com/>. The place to file it would be <http://bugreport.apple.com>.
Trevor Downs
(In reply to comment #6)
> Please file a new bug about <http://drunkduck.com/>. The place to file it would be <http://bugreport.apple.com>.
Filed at <https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa/12/wo/dXYGRK8c1Yx9XhgHuJe5sg/11.83.28.0.9>
Martin Robinson
The two icons linked from here: webkit.org and the one for http://commons.wikimedia.org/wiki/Accueil load fine for me in a recent Epiphany. Closing this bug. Please feel free to re-open if this persists. Be sure to add a link to a site where it fails and to use a recent WebKitGTK+ (1.8+ should be fine).