Bug 249712
| Summary: | <html> should be focusable if document.designMode="on" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | karlcow, rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commits, I found another one which we can merge:
Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/2e0b14d5b60afe239324c9c986745bec7f294ece
Webkit Source - https://searchfox.org/wubkat/source/Source/WebCore/dom/Element.cpp#378
^ In above add this:
|| isRootEditableElement();
https://searchfox.org/wubkat/source/Source/WebCore/dom/Node.cpp#1376
Only issue that don't have testcase.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
NOTE - Safari 16.2 matches Firefox Nightly 111 and don't have "Editable Head" as editable as of right now, on following test case:
data:text/html;charset=utf-8,<html><head><style>*%20{%20display:block;%20}</style><title>Editable%20HEAD</title></head><body>body<script>document.designMode="on"</script>
^ From Chrome Bug.
Radar WebKit Bug Importer
<rdar://problem/103742741>
Ahmad Saleem
My approach to add || isRootEditableElement(); in bool Element::supportsFocus() function does not make 'head' editable from Comment 01 test case.
Just wanted to update since I tested this in local test environment.