Bug 249672
| Summary: | commits.webkit.org cannot handle canonical URL https://commits.webkit.org/253173.313@webkitglib/2.38 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | aperez, ap, cgarcia, jbedard, jond, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
The canonical URL for commit https://github.com/WebKit/WebKit/commit/3e9403ce54e3df588a923cc4e6625c8623f9febe (as provided by 'git-webkit canonicalize') is https://commits.webkit.org/253173.313@webkitglib/2.38. But this URL just redirects to https://github.com/WebKit/WebKit/commits instead of actually displaying the commit.
I wonder if the problem is the / character in the branch name?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105076804>
Jonathan Bedard
This looks to be resolved. Which is a bit weird because I don't believe I changed anything.
Possibly our commits.webkit.org checkouts didn't used to have this branch, but do now? (Which is the other reason commits.webkit.org might not redirect to a specific commit)
Michael Catanzaro
Huh, yeah it certainly seems to be fixed. Strange, but nice.
Adrian, this means we can now start running 'git-webkit canonicalize' before pushing commits to the stable branch.
Michael Catanzaro
(In reply to Jonathan Bedard from comment #2)
> Possibly our commits.webkit.org checkouts didn't used to have this branch,
> but do now? (Which is the other reason commits.webkit.org might not redirect
> to a specific commit)
Perhaps indeed? Because 2.40 branch links are all broken, e.g. https://commits.webkit.org/260527.340@webkitglib/2.40
For 2.38, https://commits.webkit.org/253173.447@webkitglib/2.38 works fine but https://commits.webkit.org/253173.448@webkitglib/2.38 does not work. So I think commits.webkit.org is just not fetching all the branches and latest commits from them. It looks like it only knows about 2.38 changes until January.
Alexey Proskuryakov
> https://commits.webkit.org/253173.448@webkitglib/2.38 does not work.
Seems to work for me now, FWIW. It redirects to https://github.com/WebKit/WebKit/commit/1b868d373bede773c6d53049a1904ed5b729f44c
Michael Catanzaro
Huh, weird.
I just tested and https://commits.webkit.org/253173.452@webkitglib/2.38 worked but https://commits.webkit.org/253173.453@webkitglib/2.38 did not. But now, about one minute later, .453 and .454 are both working and .455 is the first that doesn't work. So the available commit range is somehow expanding.