Bug 24965

Summary: HTMLMediaElement: network state changes can be missed
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch simon.fraser: review+

Eric Carlson
Reported 2009-03-31 14:40:54 PDT
A bug in the logic of HTMLMediaElement::setNetworkState can cause a network state change to be missed.
Attachments
proposed patch (3.34 KB, patch)
2009-03-31 14:51 PDT, Eric Carlson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2009-03-31 14:51:44 PDT
Created attachment 29132 [details] proposed patch
Simon Fraser (smfr)
Comment 2 2009-03-31 15:10:34 PDT
Comment on attachment 29132 [details] proposed patch > + MediaPlayer::ReadyState currentState = m_player->readyState(); > + if (static_cast<ReadyState>(currentState) != m_readyState) This cast is pretty heinous. It would be nice to: 1. Have MediaPlayer ReadyState have a somewhat different name (PlayerReadyState). 2. Have a method that converts them: ReadyState readyStateForPlayerReadyState(PlayerReadyState) rather than casting. But those can be done in a later commit.
Eric Carlson
Comment 3 2009-03-31 15:14:11 PDT
Committed revision 42144.
Note You need to log in before you can comment on or make changes to this bug.