Bug 249621
| Summary: | Caret Line Height is not matching font size | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Joone Hur <joone> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, just1gb, ktf.kim, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While trying to find for broken testcase of HTML Editing bug, I came cross bug in line height issue in the following testcase:
Test Case - https://jsfiddle.net/tck7m2qL/
^ Try to type after the "grey" container and observer caret size (I-Beam), it would be huge and size of container in Safari 16.2 & STP160.
While Firefox Nightly 110 and Chrome Canary 111 show normal caret size (Firefox does not have any container and show in "normal" size since beginning while Chrome Canary show "Big" one till we don't type first character and then it will show "normal" caret size).
Just wanted to raise this bug so it can be tracked and if it is duplicate then please close it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103716521>
Joone Hur
Pull request: https://github.com/WebKit/WebKit/pull/16647
Ahmad Saleem
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/dd1014b38784779a347f72d4eca818eed3b12ccf
Might be potential solution to explore or in addition to current PR?
https://searchfox.org/wubkat/rev/ecf416c989d65a6cfed8592f00acadb479ebe334/Source/WebCore/rendering/CaretRectComputation.cpp#117
Joone Hur
It looks almost the same to get the caret height from the Chromium implementation and my patch. The problem seems to be that the caret isn't rendering correctly on iOS because the top was calculated incorrectly. So, I've updated the part where the top is calculated. Thanks for the info.
Joone Hur
*** Bug 13820 has been marked as a duplicate of this bug. ***
Joone Hur
*** Bug 116424 has been marked as a duplicate of this bug. ***