Bug 249545
| Summary: | Make DragController::DragIsMove return false when selection does not have focus | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | UI Events | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | akeerthi, ap, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another interesting one, which can be merged to improve further user experience:
Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/5fb678a9ee8b5e8e303ea0d66ae5efe979e6fcd2
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/c2dd7ba9890874670b16f914a46afb7c420da9ce/Source/WebCore/page/DragController.cpp#L192
Can we use "isFocusedAndActive()" from FrameSelection for this or not?
If someone can confirm then I am happy to do PR and fix this.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I tried this in following PR - https://github.com/WebKit/WebKit/pull/7928
It seems that we have add "SelectionHasFunction" function because "isFocusedAndActive" is not direct replacement.
If we create equivalent of "SelectionHasFocus" then it would be easy to fix this bug and if we don't face any other focus related bug.
I am going to close my PR but you can use it for reference:
1) Skip on iOS
2) Which line etc., in the WebKit Source etc.
3) I tried "focusedElement()" as well but got build errors.
NOTE - assert-selection.js is up to date from Chromium source, so it is not script issue as well. (at least IMO)
Radar WebKit Bug Importer
<rdar://problem/103689075>