Bug 249530
| Summary: | [web-animations] consider using Ref<> instead of RefPtr<> in the various types defined in WebAnimationTypes.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, dino, graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=249498 | ||
Antoine Quint
During review of the patch for bug 249498, Darin made a comment (https://github.com/WebKit/WebKit/pull/7780#discussion_r1051307179) that we should consider using Ref<> instead of RefPtr<> for the new AnimatablePropertyToTransitionMap. We should broadly look into using Ref<> instead of RefPtr<> for the various types defined in WebAnimationTypes.h.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103683475>
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/8361
EWS
Committed 258631@main (866813ec2e4e): <https://commits.webkit.org/258631@main>
Reviewed commits have been landed. Closing PR #8361 and removing active labels.