Bug 249498
| Summary: | [web-animations] add an AnimatableProperty type to encapsulate either a standard or custom property | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, graouts, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=249530 | ||
| Bug Depends on: | |||
| Bug Blocks: | 249399, 249533 | ||
Antoine Quint
The animation code is currently heavily biased towards dealing with "standard" CSS properties, represented by the CSSPropertyID type. However, with the work to add interpolation support for custom properties (see bug 249293) and to support CSS Transitions for custom properties (see bug 249399), we really need to deal with both custom properties and standard properties everywhere we currently deal with only standard properties. So let's add a new type, AnimatableProperty, which is an std::variant<CSSPropertyID, AtomString>.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/7780
EWS
Committed 258040@main (ea7b3989b369): <https://commits.webkit.org/258040@main>
Reviewed commits have been landed. Closing PR #7780 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/103477720>