Bug 249484
| Summary: | [ews-build.webkit.org] Support proxy Twisted requests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 250771 | ||
Jonathan Bedard
We have future plans to host ews-build.wekbit.org in a location where requests need to be made through a proxy. Twisted doesn't support 'HTTP_PROXY' environment variables as many libraries do. Additionally, it's not quite trivial to support proxy requests in Twisted. We need to implement proxy requests in Twisted and generalize them sufficiently so that we don't have to duplicate code in all places we're making requests in EWS.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103451811>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/7760
EWS
Committed 258027@main (055b0ba705b4): <https://commits.webkit.org/258027@main>
Reviewed commits have been landed. Closing PR #7760 and removing active labels.