Summary: | Accelerated compositing can sometimes flash when changing layers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Marrin <cmarrin> | ||||||
Component: | Layout and Rendering | Assignee: | Chris Marrin <cmarrin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Chris Marrin
2009-03-30 13:50:47 PDT
Created attachment 29104 [details]
Patch
Comment on attachment 29104 [details]
Patch
r- based on discussion with Darin. We need to just fix the deferred layout timer to fire at the right time.
Created attachment 29231 [details]
Replacement patch
Comment on attachment 29231 [details]
Replacement patch
r=me
Comment on attachment 29231 [details] Replacement patch > + if (!_private->useDocumentViews) > + [self _viewWillDrawInternal]; This needs an #if USE(ACCELERATED_COMPOSITING) around it, or it will throw an exception since that method wont exist. Never mind, I see the caller has the correct #ifndef around it. Sending WebCore/ChangeLog Sending WebCore/page/ChromeClient.h Sending WebCore/rendering/RenderLayerCompositor.cpp Sending WebCore/rendering/RenderLayerCompositor.h Sending WebKit/mac/ChangeLog Sending WebKit/mac/WebCoreSupport/WebChromeClient.h Sending WebKit/mac/WebCoreSupport/WebChromeClient.mm Sending WebKit/mac/WebView/WebView.mm Sending WebKit/mac/WebView/WebViewInternal.h Transmitting file data ......... Committed revision 42208. |