Summary: | Make Attr.value/nodeValue/textContent not nullable | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | cdumez, karlcow, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | BrowserCompat, InRadar |
Version: | Safari Technology Preview | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Ahmad Saleem
2022-12-14 10:07:23 PST
It seems like a good change to merge. (In reply to Ryosuke Niwa from comment #1) > It seems like a good change to merge. Cool! I will give it a go later today. Thanks for your input! I usually don't touch IDL files (fear of unknown). :-) void Attr::setNodeValue(const String& value) { const AtomString valueWithoutNull = value.isNull() ? emptyAtom() : AtomString(value); setValue(valueWithoutNull); } ^ This fixes failing test case locally. Can do PR later. Thanks! Committed 265769@main (2da4c96001cf): <https://commits.webkit.org/265769@main> Reviewed commits have been landed. Closing PR #15550 and removing active labels. |