Bug 249320
| Summary: | [web-animations] Refactor CSSPropertyAnimation::blendProperties() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 249293 | ||
Antoine Quint
During a pull request review (https://github.com/WebKit/WebKit/pull/7615#discussion_r1048703175), Antti made the point that the CSSPropertyBlendingClient parameters which are always pointers ought to be reference since they're never null.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
Actually, we'll reuse this bug for a more general refactoring of CSSPropertyAnimation::blendProperties() to deal with not only a reference for CSSPropertyBlendingClient but also a variant parameter for the property to deal with both standard properties and custom properties.
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/7678
EWS
Committed 257910@main (24ceea27a0d5): <https://commits.webkit.org/257910@main>
Reviewed commits have been landed. Closing PR #7678 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/103396354>