Bug 24927

Summary:

Avoid empty ResourceError objects in CURL / wx ports

Product:

WebKit

Reporter:

Kevin Ollivier <kevino>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, mr.diggilin

Priority:

Keywords:

Curl, Wx

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
CURL fix for empty ResourceError object problem	mjs: review+
wx fixes for empty ResourceError objects	mjs: review+

Kevin Ollivier

Reported 2009-03-29 16:43:41 PDT

WebCore::DocumentLoader::mainReceivedError now asserts if error.isNull(), and other places may start asserting too, so we need to fill out the ResourceError objects.

Attachments
CURL fix for empty ResourceError object problem (1.33 KB, patch) 2009-03-29 16:44 PDT, Kevin Ollivier	mjs: review+	Details Formatted Diff Diff
wx fixes for empty ResourceError objects (5.68 KB, patch) 2009-03-29 16:44 PDT, Kevin Ollivier	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kevin Ollivier

Comment 1 2009-03-29 16:44:20 PDT

Created attachment 29049 [details] CURL fix for empty ResourceError object problem

Kevin Ollivier

Comment 2 2009-03-29 16:44:54 PDT

Created attachment 29050 [details] wx fixes for empty ResourceError objects

Maciej Stachowiak

Comment 3 2009-05-09 14:58:20 PDT

Comment on attachment 29049 [details] CURL fix for empty ResourceError object problem r=me

Maciej Stachowiak

Comment 4 2009-05-09 14:58:41 PDT

Comment on attachment 29050 [details] wx fixes for empty ResourceError objects r=me

Kevin Ollivier

Comment 5 2009-05-09 15:42:03 PDT

Landed in r43442, thanks!

Note You need to log in before you can comment on or make changes to this bug.