Bug 249166
| Summary: | [ews-build.webkit.org] Don't consult results.webkit.org for non-main PRs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, jbedard, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | Safari 15 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Rob Buis
Today I have seen exception as build result for the layout test run:
https://ews-build.webkit.org/#/builders/70/builds/23670
https://ews-build.webkit.org/#/builders/70/builds/23553
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
builtins.ValueError: Invalid URI b'https://results.webkit.org/api/results-summary/layout-tests/gamepad/gamepad-polling-access.html?platform=mac&style=release&flavor=wk2&ref=0 detached at 1d7abcd180ab)'
Jonathan Bedard
Had already landed a fix for the exception, at least, in https://commits.webkit.org/257674@main. But the invalid URI is a bit weird...
Jonathan Bedard
The weird URI is because the PR isn't targeting main. With the proper error fallback, we actually would have behaved sanely, but we really shouldn't trigger this logic at all if we aren't making a PR against `main`.
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/7526
EWS
Committed 257819@main (14dcf9a35beb): <https://commits.webkit.org/257819@main>
Reviewed commits have been landed. Closing PR #7526 and removing active labels.