Bug 249088 – [@property] Support <image> and <url> syntax

• Component: CSS
• Status: RESOLVED FIXED

[Antti Koivisto]

More syntax

[Radar WebKit Bug Importer]

<rdar://problem/103224027>

[Antti Koivisto]

Created attachment 463983 [details]
Patch

[Antti Koivisto]

Created attachment 463984 [details]
Patch

[EWS]

Committed 257701@main (65a79bcd6331): <https://commits.webkit.org/257701@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463984 [details].

[Philippe Normand]

This broke linux clang builds:

https://build.webkit.org/#/builders/629/builds/1047


/app/webkit/WebKitBuild/Release/WTF/Headers/wtf/RefPtr.h:125:7: error: cannot initialize a member subobject of type 'typename PtrTraits::StorageType' (aka 'WebCore::StyleImage *') with an rvalue of type 'WebCore::CSSVariableReferenceValue *'
    : m_ptr(&reference.leakRef())
      ^     ~~~~~~~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-unknown-linux-gnu/12.1.0/../../../../include/c++/12.1.0/variant:284:6: note: in instantiation of function template specialization 'WTF::RefPtr<WebCore::StyleImage>::RefPtr<WebCore::CSSVariableReferenceValue, WTF::RawPtrTraits<WebCore::CSSVariableReferenceValue>>' requested here
            _Type(std::forward<_Args>(__args)...);
            ^
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/Settings.cpp:29:
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/Settings.h:30:
In file included from /app/webkit/Source/WebCore/page/SettingsBase.h:30:
In file included from /app/webkit/Source/WebCore/platform/ContentType.h:29:
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/text/WTFString.h:28:
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/text/StringImpl.h:29:
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/CompactPtr.h:32:
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/HashFunctions.h:26:
/app/webkit/WebKitBuild/Release/WTF/Headers/wtf/RefPtr.h:125:7: error: cannot initialize a member subobject of type 'typename PtrTraits::StorageType' (aka 'WebCore::StyleImage *') with an rvalue of type 'WebCore::CSSVariableData *'
    : m_ptr(&reference.leakRef())
      ^     ~~~~~~~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-unknown-linux-gnu/12.1.0/../../../../include/c++/12.1.0/variant:284:6: note: in instantiation of function template specialization 'WTF::RefPtr<WebCore::StyleImage>::RefPtr<WebCore::CSSVariableData, WTF::RawPtrTraits<WebCore::CSSVariableData>>' requested here
            _Type(std::forward<_Args>(__args)...);
            ^
2 errors generated.
[7/566] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp.o
FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp.o 
/usr/bin/ccache /usr/lib/sdk/llvm14/bin/clang++ -DBUILDING_GTK__=1 -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WebKitGTK-4.1\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_PAL -DUSE_SYSTEM_EGL -I/app/webkit/WebKitBuild/Release -I/app/webkit/WebKitBuild/Release/WebCore/DerivedSources -I/app/webkit/Source/WebCore -I/app/webkit/Source/WebCore/Modules/WebGPU -I/app/webkit/Source/WebCore/Modules/airplay -I/app/webkit/Source/WebCore/Modules/applepay -I/app/webkit/Source/WebCore/Modules/applepay/paymentrequest -I/app/webkit/Source/WebCore/Modules/applicationmanifest -I/app/webkit/Source/WebCore/Modules/async-clipboard -I/app/webkit/Source/WebCore/Modules/audiosession -I/app/webkit/Source/WebCore/Modules/beacon -I/app/webkit/Source/WebCore/Modules/cache -I/app/webkit/Source/WebCore/Modules/compression -I/app/webkit/Source/WebCore/Modules/contact-picker -I/app/webkit/Source/WebCore/Modules/cookie-consent -I/app/webkit/Source/WebCore/Modules/credentialmanagement -I/app/webkit/Source/WebCore/Modules/encryptedmedia -I/app/webkit/Source/WebCore/Modules/encryptedmedia/legacy -I/app/webkit/Source/WebCore/Modules/entriesapi -I/app/webkit/Source/WebCore/Modules/fetch -I/app/webkit/Source/WebCore/Modules/filesystemaccess -I/app/webkit/Source/WebCore/Modules/geolocation -I/app/webkit/Source/WebCore/Modules/highlight -I/app/webkit/Source/WebCore/Modules/indexeddb -I/app/webkit/Source/WebCore/Modules/indexeddb/client -I/app/webkit/Source/WebCore/Modules/indexeddb/server -I/app/webkit/Source/WebCore/Modules/indexeddb/shared -I/app/webkit/Source/WebCore/Modules/mediacapabilities -I/app/webkit/Source/WebCore/Modules/mediacontrols -I/app/webkit/Source/WebCore/Modules/mediarecorder -I/app/webkit/Source/WebCore/Modules/mediasession -I/app/webkit/Source/WebCore/Modules/mediasource -I/app/webkit/Source/WebCore/Modules/mediastream -I/app/webkit/Source/WebCore/Modules/model-element -I/app/webkit/Source/WebCore/Modules/model-element/dummy -I/app/webkit/Source/WebCore/Modules/navigatorcontentutils -I/app/webkit/Source/WebCore/Modules/notifications -I/app/webkit/Source/WebCore/Modules/paymentrequest -I/app/webkit/Source/WebCore/Modules/permissions -I/app/webkit/Source/WebCore/Modules/pictureinpicture -I/app/webkit/Source/WebCore/Modules/plugins -I/app/webkit/Source/WebCore/Modules/push-api -I/app/webkit/Source/WebCore/Modules/remoteplayback -I/app/webkit/Source/WebCore/Modules/reporting -I/app/webkit/Source/WebCore/Modules/screen-wake-lock -I/app/webkit/Source/WebCore/Modules/speech -I/app/webkit/Source/WebCore/Modules/storage -I/app/webkit/Source/WebCore/Modules/streams -I/app/webkit/Source/WebCore/Modules/web-locks -I/app/webkit/Source/WebCore/Modules/webaudio -I/app/webkit/Source/WebCore/Modules/webauthn -I/app/webkit/Source/WebCore/Modules/webauthn/cbor -I/app/webkit/Source/WebCore/Modules/webauthn/fido -I/app/webkit/Source/WebCore/Modules/webcodecs -I/app/webkit/Source/WebCore/Modules/webdatabase -I/app/webkit/Source/WebCore/Modules/webdriver -I/app/webkit/Source/WebCore/Modules/websockets -I/app/webkit/Source/WebCore/Modules/webxr -I/app/webkit/Source/WebCore/accessibility -I/app/webkit/Source/WebCore/accessibility/isolatedtree -I/app/webkit/Source/WebCore/animation -I/app/webkit/Source/WebCore/bindings -I/app/webkit/Source/WebCore/bindings/js -I/app/webkit/Source/WebCore/bridge -I/app/webkit/Source/WebCore/bridge/c -I/app/webkit/Source/WebCore/bridge/jsc -I/app/webkit/Source/WebCore/contentextensions -I/app/webkit/Source/WebCore/crypto -I/app/webkit/Source/WebCore/crypto/algorithms -I/app/webkit/Source/WebCore/crypto/keys -I/app/webkit/Source/WebCore/crypto/parameters -I/app/webkit/Source/WebCore/css -I/app/webkit/Source/WebCore/css/calc -I/app/webkit/Source/WebCore/css/parser -I/app/webkit/Source/WebCore/css/query -I/app/webkit/Source/WebCore/css/typedom -I/app/webkit/Source/WebCore/css/typedom/color -I/app/webkit/Source/WebCore/css/typedom/numeric -I/app/webkit/Source/WebCore/css/typedom/transform -I/app/webkit/Source/WebCore/cssjit -I/app/webkit/Source/WebCore/display -I/app/webkit/Source/WebCore/display/compositing -I/app/webkit/Source/WebCore/display/css -I/app/webkit/Source/WebCore/dom -I/app/webkit/Source/WebCore/dom/messageports -I/app/webkit/Source/WebCore/domjit -I/app/webkit/Source/WebCore/editing -I/app/webkit/Source/WebCore/fileapi -I/app/webkit/Source/WebCore/history -I/app/webkit/Source/WebCore/html -I/app/webkit/Source/WebCore/html/canvas -I/app/webkit/Source/WebCore/html/forms -I/app/webkit/Source/WebCore/html/parser -I/app/webkit/Source/WebCore/html/shadow -I/app/webkit/Source/WebCore/html/track -I/app/webkit/Source/WebCore/inspector -I/app/webkit/Source/WebCore/inspector/agents -I/app/webkit/Source/WebCore/inspector/agents/page -I/app/webkit/Source/WebCore/inspector/agents/worker -I/app/webkit/Source/WebCore/layout -I/app/webkit/Source/WebCore/layout/formattingContexts -I/app/webkit/Source/WebCore/layout/formattingContexts/block -I/app/webkit/Source/WebCore/layout/formattingContexts/block/tablewrapper -I/app/webkit/Source/WebCore/layout/formattingContexts/flex -I/app/webkit/Source/WebCore/layout/floats -I/app/webkit/Source/WebCore/layout/formattingContexts/inline -I/app/webkit/Source/WebCore/layout/formattingContexts/inline/display -I/app/webkit/Source/WebCore/layout/formattingContexts/inline/invalidation -I/app/webkit/Source/WebCore/layout/formattingContexts/inline/text -I/app/webkit/Source/WebCore/layout/integration -I/app/webkit/Source/WebCore/layout/integration/flex -I/app/webkit/Source/WebCore/layout/integration/inline -I/app/webkit/Source/WebCore/layout/layouttree -I/app/webkit/Source/WebCore/layout/formattingContexts/table -I/app/webkit/Source/WebCore/loader -I/app/webkit/Source/WebCore/loader/appcache -I/app/webkit/Source/WebCore/loader/archive -I/app/webkit/Source/WebCore/loader/archive/mhtml -I/app/webkit/Source/WebCore/loader/cache -I/app/webkit/Source/WebCore/loader/icon -I/app/webkit/Source/WebCore/mathml -I/app/webkit/Source/WebCore/page -I/app/webkit/Source/WebCore/page/csp -I/app/webkit/Source/WebCore/page/scrolling -I/app/webkit/Source/WebCore/platform -I/app/webkit/Source/WebCore/platform/animation -I/app/webkit/Source/WebCore/platform/audio -I/app/webkit/Source/WebCore/platform/calc -I/app/webkit/Source/WebCore/platform/encryptedmedia -I/app/webkit/Source/WebCore/platform/gamepad -I/app/webkit/Source/WebCore/platform/graphics -I/app/webkit/Source/WebCore/platform/graphics/cpu/arm -I/app/webkit/Source/WebCore/platform/graphics/cpu/arm/filters -I/app/webkit/Source/WebCore/platform/graphics/displaylists -I/app/webkit/Source/WebCore/platform/graphics/filters -I/app/webkit/Source/WebCore/platform/graphics/filters/software -I/app/webkit/Source/WebCore/platform/graphics/iso -I/app/webkit/Source/WebCore/platform/graphics/opentype -I/app/webkit/Source/WebCore/platform/graphics/transforms -I/app/webkit/Source/WebCore/platform/mediacapabilities -I/app/webkit/Source/WebCore/platform/mediarecorder -I/app/webkit/Source/WebCore/platform/mediastream -I/app/webkit/Source/WebCore/platform/mock -I/app/webkit/Source/WebCore/platform/mock/mediasource -I/app/webkit/Source/WebCore/platform/network -I/app/webkit/Source/WebCore/platform/sql -I/app/webkit/Source/WebCore/platform/text -I/app/webkit/Source/WebCore/platform/xr -I/app/webkit/Source/WebCore/plugins -I/app/webkit/Source/WebCore/rendering -I/app/webkit/Source/WebCore/rendering/line -I/app/webkit/Source/WebCore/rendering/mathml -I/app/webkit/Source/WebCore/rendering/shapes -I/app/webkit/Source/WebCore/rendering/style -I/app/webkit/Source/WebCore/rendering/svg -I/app/webkit/Source/WebCore/rendering/updating -I/app/webkit/Source/WebCore/replay -I/app/webkit/Source/WebCore/storage -I/app/webkit/Source/WebCore/style -I/app/webkit/Source/WebCore/svg -I/app/webkit/Source/WebCore/svg/animation -I/app/webkit/Source/WebCore/svg/graphics -I/app/webkit/Source/WebCore/svg/graphics/filters -I/app/webkit/Source/WebCore/svg/properties -I/app/webkit/Source/WebCore/websockets -I/app/webkit/Source/WebCore/workers -I/app/webkit/Source/WebCore/workers/service -I/app/webkit/Source/WebCore/workers/service/context -I/app/webkit/Source/WebCore/workers/service/server -I/app/webkit/Source/WebCore/workers/shared -I/app/webkit/Source/WebCore/workers/shared/context -I/app/webkit/Source/WebCore/worklets -I/app/webkit/Source/WebCore/xml -I/app/webkit/Source/WebCore/xml/parser -I/app/webkit/Source/WebCore/Modules/gamepad -I/app/webkit/Source/WebCore/platform/encryptedmedia/clearkey -I/app/webkit/Source/WebCore/platform/graphics/angle -I/app/webkit/Source/WebCore/platform/graphics/lcms -I/app/webkit/Source/ThirdParty/xdgmime/src -I/app/webkit/Source/WebCore/platform/graphics/cairo -I/app/webkit/Source/WebCore/platform/graphics/freetype -I/app/webkit/Source/WebCore/platform/graphics/harfbuzz -I/app/webkit/Source/WebCore/platform/graphics/harfbuzz/ng -I/app/webkit/Source/WebCore/Modules/mediastream/gstreamer -I/app/webkit/Source/WebCore/platform/graphics/gstreamer -I/app/webkit/Source/WebCore/platform/graphics/gstreamer/mse -I/app/webkit/Source/WebCore/platform/graphics/gstreamer/eme -I/app/webkit/Source/WebCore/platform/gstreamer -I/app/webkit/Source/WebCore/platform/mediarecorder/gstreamer -I/app/webkit/Source/WebCore/platform/audio/gstreamer -I/app/webkit/Source/WebCore/platform/image-decoders -I/app/webkit/Source/WebCore/platform/image-decoders/avif -I/app/webkit/Source/WebCore/platform/image-decoders/bmp -I/app/webkit/Source/WebCore/platform/image-decoders/gif -I/app/webkit/Source/WebCore/platform/image-decoders/ico -I/app/webkit/Source/WebCore/platform/image-decoders/jpeg -I/app/webkit/Source/WebCore/platform/image-decoders/jpeg2000 -I/app/webkit/Source/WebCore/platform/image-decoders/jpegxl -I/app/webkit/Source/WebCore/platform/image-decoders/png -I/app/webkit/Source/WebCore/platform/image-decoders/webp -I/app/webkit/Source/WebCore/platform/network/soup -I/app/webkit/Source/WebCore/platform/graphics/texmap -I/app/webkit/Source/WebCore/platform/graphics/nicosia -I/app/webkit/Source/WebCore/page/scrolling/nicosia -I/app/webkit/Source/WebCore/platform/graphics/texmap/coordinated -I/app/webkit/Source/WebCore/platform/graphics/nicosia/cairo -I/app/webkit/Source/WebCore/platform/graphics/nicosia/texmap -I/app/webkit/Source/WebCore/accessibility/atspi -I/app/webkit/Source/WebCore/crypto/openssl -I/app/webkit/Source/WebCore/page/gtk -I/app/webkit/Source/WebCore/platform/adwaita -I/app/webkit/Source/WebCore/platform/audio/glib -I/app/webkit/Source/WebCore/platform/generic -I/app/webkit/Source/WebCore/platform/glib -I/app/webkit/Source/WebCore/platform/gtk -I/app/webkit/Source/WebCore/platform/graphics/egl -I/app/webkit/Source/WebCore/platform/graphics/epoxy -I/app/webkit/Source/WebCore/platform/graphics/glx -I/app/webkit/Source/WebCore/platform/graphics/gbm -I/app/webkit/Source/WebCore/platform/graphics/gtk -I/app/webkit/Source/WebCore/platform/graphics/libwpe -I/app/webkit/Source/WebCore/platform/graphics/opengl -I/app/webkit/Source/WebCore/platform/graphics/wayland -I/app/webkit/Source/WebCore/platform/graphics/x11 -I/app/webkit/Source/WebCore/platform/mediastream/gtk -I/app/webkit/Source/WebCore/platform/mediastream/gstreamer -I/app/webkit/Source/WebCore/platform/network/glib -I/app/webkit/Source/WebCore/platform/text/gtk -I/app/webkit/WebKitBuild/Release/ANGLE/Headers -I/app/webkit/WebKitBuild/Release/JavaScriptCore/Headers -I/app/webkit/WebKitBuild/Release/JavaScriptCore/PrivateHeaders -I/app/webkit/WebKitBuild/Release/JavaScriptCoreGLib/Headers -I/app/webkit/WebKitBuild/Release/JavaScriptCoreGLib/DerivedSources -I/app/webkit/WebKitBuild/Release/WTF/Headers -I/app/webkit/WebKitBuild/Release/bmalloc/Headers -I/app/webkit/WebKitBuild/Release/PAL/Headers -isystem /usr/include/gstreamer-1.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/orc-0.4 -isystem /usr/lib/x86_64-linux-gnu/gstreamer-1.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/WPEFramework/ocdm -isystem /usr/include/libsoup-3.0 -isystem /usr/include/enchant-2 -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/libsecret-1 -isystem /usr/include/libdrm -isystem /usr/include/libxml2 -isystem /usr/include/cairo -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/openjpeg-2.5 -isystem /usr/include/avif -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/libpng16 -isystem /usr/include/fribidi -isystem /usr/include/pixman-1 -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/atk-1.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem /usr/include/dbus-1.0 -isystem /usr/lib/x86_64-linux-gnu/dbus-1.0/include -isystem /usr/include/at-spi-2.0 -isystem /usr/include/wpe-1.0 -isystem /usr/include/libmanette -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIC -fvisibility=hidden -I/usr/include/x86_64-linux-gnu -DAVIF_DLL -pthread -DWPE_ENABLE_XKB=1 -std=c++20 -MD -MT Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp.o -MF Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp.o -c /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp:1:
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/CSSPropertyParsing.cpp:4:
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/CSSPropertyParsing.h:5:
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/CSSPropertyNames.h:6:
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/HashFunctions.h:26:
/app/webkit/WebKitBuild/Release/WTF/Headers/wtf/RefPtr.h:125:7: error: cannot initialize a member subobject of type 'typename PtrTraits::StorageType' (aka 'WebCore::StyleImage *') with an rvalue of type 'WebCore::CSSVariableReferenceValue *'
    : m_ptr(&reference.leakRef())
      ^     ~~~~~~~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-unknown-linux-gnu/12.1.0/../../../../include/c++/12.1.0/variant:284:6: note: in instantiation of function template specialization 'WTF::RefPtr<WebCore::StyleImage>::RefPtr<WebCore::CSSVariableReferenceValue, WTF::RawPtrTraits<WebCore::CSSVariableReferenceValue>>' requested here
            _Type(std::forward<_Args>(__args)...);
            ^
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-1.cpp:1:
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/CSSPropertyParsing.cpp:4:
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/CSSPropertyParsing.h:5:
In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/CSSPropertyNames.h:6:
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/HashFunctions.h:26:
/app/webkit/WebKitBuild/Release/WTF/Headers/wtf/RefPtr.h:125:7: error: cannot initialize a member subobject of type 'typename PtrTraits::StorageType' (aka 'WebCore::StyleImage *') with an rvalue of type 'WebCore::CSSVariableData *'
    : m_ptr(&reference.leakRef())
      ^     ~~~~~~~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-unknown-linux-gnu/12.1.0/../../../../include/c++/12.1.0/variant:284:6: note: in instantiation of function template specialization 'WTF::RefPtr<WebCore::StyleImage>::RefPtr<WebCore::CSSVariableData, WTF::RawPtrTraits<WebCore::CSSVariableData>>' requested here
            _Type(std::forward<_Args>(__args)...);
            ^
2 errors generated.

[Philippe Normand]

Manually reverted, see https://bugs.webkit.org/show_bug.cgi?id=249133

[Philippe Normand]

Revert no longer needed.