run-webkit-tests unable to set timeout manually

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brian Weinstein]

run-webkit-tests is currently unable to set the timeout time through a command line argument, which can mean tests are either running for too long (multiple timeouts where the system is in a broken state), or too short (want tests to timeout more quickly, but there are some longer tests).

[Mark Rowe (bdash)]

If tests are taking so long that they're timing out then either the test needs simplified or split, the code being tested improved so that the test doesn't take so long, or the timeout raised.  I'm not sure why a command-line argument would be necessary here.

[Brian Weinstein]

Created attachment 29035 [details]
Timeout able to be set as an argument

[Darin Adler]

Comment on attachment 29035 [details]
Timeout able to be set as an argument

The other arguments are mostly in alphabetical order except for merge-leak-depth in the usage message. It would be good to keep them sorted.

I'm not sure --timeout-seconds is better than just --timeout

r=me though

[Brian Weinstein]

Created attachment 29107 [details]
Fix argument order, --timeout instead of --timeout-seconds

Made the quick fixes requested by Darin

[Adam Roben (:aroben)]

Comment on attachment 29107 [details]
Fix argument order, --timeout instead of --timeout-seconds

> +  --timeout                       Sets the length of time before a test times out

The Usage output should indicate that --timeout takes a parameter. It would be good for it to also say what the default value is.

> +    'timeout-seconds=i' => \$timeoutSeconds,

This wasn't changed to match the new name of the option.

Your ChangeLog should also mention that this patch changes the default value back to 60 seconds from 15. Or your patch keep the default at 15 seconds (which might be better).

r- since the code doesn't match the Usage statement.

[Brian Weinstein]

Created attachment 29125 [details]
Allows run-webkit-tests to specify timeout

Fixed silly mistakes in last patch.

[Adam Roben (:aroben)]

Landed in r42292