Bug 24890

Summary: Navigation actions are not updated when browsing a site that uses frames.
Product: WebKit Reporter: Benjamin Meyer <ben>
Component: WebKit QtAssignee: Benjamin Meyer <ben>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, manyoso
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
path with test and changlog
none
patch to fix the bug
none
ver 3
none
ver4
none
ver5
hausmann: review+
update last patch to apply to head none

Description Benjamin Meyer 2009-03-27 11:14:25 PDT 
launching the browser to a site that has frames the back button will be disabled.  If you click on a link that loads a url in another frame the back button show now be enabled.  The QWebHistory does get updated, just the action isn't updated.

Patch with test included.
Comment 1 Benjamin Meyer 2009-03-27 11:21:49 PDT 
Created attachment 29015 [details]
path with test and changlog
Comment 2 Benjamin Meyer 2009-03-27 11:23:07 PDT 
Simon: looking at the history of this line of code it was all originally written by you in the action update commits.  Can you please review this patch?  Thanks.
Comment 3 Benjamin Meyer 2009-03-31 08:44:52 PDT 
Created attachment 29116 [details]
patch to fix the bug

Version 2 of the patch, put the test files in a resource
Comment 4 Benjamin Meyer 2009-03-31 08:52:47 PDT 
Created attachment 29117 [details]
ver 3

put html files in the webpage dir
Comment 5 Benjamin Meyer 2009-03-31 08:56:02 PDT 
Created attachment 29118 [details]
ver4
Comment 6 Benjamin Meyer 2009-03-31 08:57:51 PDT 
Created attachment 29119 [details]
ver5
Comment 7 Simon Hausmann 2009-03-31 09:01:59 PDT 
Comment on attachment 29119 [details]
ver5

Good catch
Comment 8 Benjamin Meyer 2009-04-15 10:50:30 PDT 
Created attachment 29503 [details]
update last patch to apply to head
Comment 9 Eric Seidel (no email) 2009-04-29 14:38:25 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/qt/ChangeLog
	M	WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
	A	WebKit/qt/tests/qwebpage/frametest/frame_a.html
	A	WebKit/qt/tests/qwebpage/frametest/index.html
	M	WebKit/qt/tests/qwebpage/qwebpage.pro
	M	WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
	A	WebKit/qt/tests/qwebpage/tst_qwebpage.qrc
Committed r43015