Bug 248449
| Summary: | REGRESSION(257041@main): [ macOS ] 2X transitions/ (Layout-Tests are constant timeouts | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Jenner <jenner> |
| Component: | CSS | Assignee: | Oriol Brufau <obrufau> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | obrufau, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Robert Jenner
The following two transitions/ (Layout-tests) are constant timeouts on macOS starting at 257041@main:
transitions/shorthand-transitions.html
transitions/border-radius-transition.html
HISTORY:
https://results.webkit.org/?platform=mac&suite=layout-tests&suite=layout-tests&test=transitions%2Fborder-radius-transition.html&test=transitions%2Fshorthand-transitions.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102742539>
Robert Jenner
I was able to reproduce the timeouts at Ventura Debug ToT running the test as follows:
run-webkit-tests <insert_test_here>
EWS
Test gardening commit 257098@main (e9b769950822): <https://commits.webkit.org/257098@main>
Reviewed commits have been landed. Closing PR #6902 and removing active labels.
Robert Jenner
I tried running the tests with the --no-timeout flag as well. After 10 minutes each the tests never ran. So these do appear to be legit timeouts, and not just slow tests.
So I've added [ Timeout ] to the test's expectations at the commit above.
It should also be noted that both of these tests were failing before 257041@main. There is just an expectation marked as [ Pass Failure ]
Robert Jenner
Starting on Oriol who committed the change that caused these two tests to constantly timeout.
Oriol Brufau
Ah, that's because I made getComputedStyle().getPropertyCSSValue() consistently return a CSSValuePair, which throws when transition-test-helpers.js attempts to use getFloatValue().
The solution seems to use getPropertyValue() instead.
Also adding a try..catch seems a good idea.
Oriol Brufau
Pull request: https://github.com/WebKit/WebKit/pull/6915
EWS
Committed 257208@main (4ee897dd423c): <https://commits.webkit.org/257208@main>
Reviewed commits have been landed. Closing PR #6915 and removing active labels.
Simon Fraser (smfr)
There's equivalent code in LayoutTests/animations/animation-test-helpers.js (sadly)