Bug 248448

Summary: [leading-trim] Add support for parsing "text-edge" CSS property
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, changseok, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, obrufau, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 248612    
Bug Blocks: 245599    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
[fast-cq]Patch
none
Patch none

alan
Reported 2022-11-28 17:21:52 PST
ssia
Attachments
Patch (24.95 KB, patch)
2022-11-28 17:38 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (25.08 KB, patch)
2022-11-28 18:19 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (25.66 KB, patch)
2022-11-28 20:52 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (33.29 KB, patch)
2022-11-29 11:00 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (37.60 KB, patch)
2022-11-30 12:37 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (38.24 KB, patch)
2022-12-01 14:08 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-11-28 17:38:37 PST
Created attachment 463775 [details] Patch
alan
Comment 2 2022-11-28 18:19:39 PST
Created attachment 463776 [details] Patch
alan
Comment 3 2022-11-28 20:52:56 PST
Created attachment 463778 [details] Patch
alan
Comment 4 2022-11-29 11:00:24 PST
Created attachment 463790 [details] Patch
alan
Comment 5 2022-11-30 12:37:56 PST
Created attachment 463812 [details] [fast-cq]Patch
EWS
Comment 6 2022-12-01 06:12:19 PST
Committed 257233@main (5cecbfbd8605): <https://commits.webkit.org/257233@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463812 [details].
Radar WebKit Bug Importer
Comment 7 2022-12-01 06:13:18 PST
<rdar://problem/102858086>
WebKit Commit Bot
Comment 8 2022-12-01 09:58:16 PST
Re-opened since this is blocked by bug 248612
alan
Comment 9 2022-12-01 14:08:04 PST
Created attachment 463843 [details] Patch
EWS
Comment 10 2022-12-02 12:40:24 PST
Committed 257306@main (271f21cba431): <https://commits.webkit.org/257306@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463843 [details].
Oriol Brufau
Comment 11 2022-12-02 21:35:42 PST
cssom-getPropertyValue-common-checks.html was rightly complaining that getComputedStyle().textEdge returns "leading leading", which is not accepted by the parser. Instead of adding this to the list of existing failures, it would have been better to fix the parser or the serialization.
Note You need to log in before you can comment on or make changes to this bug.