Bug 248434
| Summary: | Potential Crash fix by not propagating empty value for face attribute | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, mmaxfield, ntim, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across following crash fix, which can be applied to Webkit:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=190788
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/b9824fc290ac9247e8a04f38632a8fdd4b9ec02d/Source/WebCore/html/HTMLFontElement.cpp#L193
Safari does not crash with the test case but I think it would be good to be safe.
I will let others to confirm whether we should merge this or not.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
https://github.com/WebKit/WebKit/pull/6964
EWS
Committed 257248@main (7f50b6d09b38): <https://commits.webkit.org/257248@main>
Reviewed commits have been landed. Closing PR #6964 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102870770>