Bug 248394 – Remove KeyboardEvent.altGraphKey

• Component: UI Events
• Status: RESOLVED FIXED

[Ahmad Saleem]

Hi Team,

Just going through Blink's commit, I came across another, which if needed, we can merge to remove "KeyboardEvent.altGraphKey":

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=179545

It was Webkit only attribute and it is now removed from Blink as well.

It seems that we still have this - https://github.com/WebKit/WebKit/blob/3a4c0cbdfa7b088c28fcb57dd3a1c5889af5c58a/Source/WebCore/dom/KeyboardEvent.cpp#L166

Just wanted to raise this bug.

Thanks!

[Ryosuke Niwa]

This flag might to be in use at first glance:
https://github.com/search?q=altGraphKey+language%3AJavaScript&type=code&l=JavaScript

[Radar WebKit Bug Importer]

<rdar://problem/102980723>

[Ahmad Saleem]

(In reply to Ryosuke Niwa from comment #1)
> This flag might to be in use at first glance:
> https://github.com/
> search?q=altGraphKey+language%3AJavaScript&type=code&l=JavaScript

Cool! I just raised it since it mentioned that it was Webkit only and non-standard and returns always "false". Still good to track for future purposes.

[Tim Nguyen (:ntim)]

(In reply to Ryosuke Niwa from comment #1)
> This flag might to be in use at first glance:
> https://github.com/
> search?q=altGraphKey+language%3AJavaScript&type=code&l=JavaScript

If it's always false in WebKit, there shouldn't be any fallout. All the usages from that search are in checks. After removing, altGraphKey will be undefined, which is still falsy.

[Ahmad Saleem]

Just came across this from another bug, using this test case:

https://guacamole.apache.org/pub/tests/key-event-test.html

Pressing any key - altGraphKey is 'undefined' for Firefox & Chrome while 'false' for Safari.

[Ahmad Saleem]

PR - https://github.com/WebKit/WebKit/pull/23015

[EWS]

Committed 273379@main (f1f9f0045afe): <https://commits.webkit.org/273379@main>

Reviewed commits have been landed. Closing PR #23015 and removing active labels.