Bug 248289

Summary: [CMake][Win] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CMakeAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, pvollan, ross.kirsling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 248246    
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2022-11-23 13:53:47 PST
[CMake][MSVC] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing CMake 3.15 introduced CMP0091 and CMAKE_MSVC_RUNTIME_LIBRARY. https://cmake.org/cmake/help/latest/policy/CMP0091.html https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html AppleWin bots are using 3.21.3 (bug#231905 comment#2)
Attachments
Patch (6.20 KB, patch)
2022-11-23 16:21 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (6.17 KB, patch)
2022-11-27 12:42 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-11-23 16:21:35 PST
Created attachment 463699 [details] Patch
Fujii Hironori
Comment 2 2022-11-23 16:49:02 PST
Comment on attachment 463699 [details] Patch Umm, jsc EWS failed. > CMake Error at Source/JavaScriptCore/CMakeLists.txt:2 (cmake_policy): > Policy "CMP0091" is not known to this version of CMake.
Don Olmstead
Comment 3 2022-11-26 17:52:41 PST
Comment on attachment 463699 [details] Patch Bots are now happy so this is good to go
Fujii Hironori
Comment 4 2022-11-27 12:21:36 PST
*** Bug 248246 has been marked as a duplicate of this bug. ***
Fujii Hironori
Comment 5 2022-11-27 12:42:52 PST
Created attachment 463744 [details] Patch
EWS
Comment 6 2022-11-27 16:48:22 PST
Committed 257053@main (121756da7448): <https://commits.webkit.org/257053@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463744 [details].
Note You need to log in before you can comment on or make changes to this bug.