Bug 248246

Summary: [CMake] Bump cmake_minimum_required version to 3.16
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: CMakeAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aperez, don.olmstead, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221727
Bug Depends on: 248289    
Bug Blocks: 248202    
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Fujii Hironori
Reported 2022-11-22 12:57:04 PST
[CMake] Bump cmake_minimum_required version to 3.16.3 https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy https://packages.ubuntu.com/focal/cmake See also: Bug 221727 – [CMake] Bump cmake_minimum_required version to 3.12 or later
Attachments
Patch (2.70 KB, patch)
2022-11-22 13:12 PST, Fujii Hironori 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-11-22 13:12:51 PST
Created attachment 463677 [details] Patch
Don Olmstead
Comment 2 2022-11-22 13:28:19 PST
Comment on attachment 463677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463677&action=review > Source/JavaScriptCore/CMakeLists.txt:1 > +cmake_minimum_required(VERSION 3.16.3) The feature you want to use is in 3.16 so I think you should use that as the minimum version not what the CMake version of the GTK policy is.
Fujii Hironori
Comment 3 2022-11-23 13:56:39 PST
AppleWin EWS failed. I'm going to fix it in another bug. Bug 248289 – [CMake][MSVC] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing
Fujii Hironori
Comment 4 2022-11-27 12:21:36 PST
I wanted to split patches, but it turned out that I should land both changes as a single commit. Merged this into bug#248289. *** This bug has been marked as a duplicate of bug 248289 ***
Note You need to log in before you can comment on or make changes to this bug.