Bug 248199
| Summary: | Remove Quirk for shouldAutoplayForArbitraryUserGesture on twitter.com and Facebook.com | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | Media | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 176402, 211932, 220834 | ||
| Bug Blocks: | |||
Karl Dubost
See https://github.com/WebKit/WebKit/blob/a0b92719854d2bb1e7cdf41c3d4cedc514ba3a3e/Source/WebCore/page/Quirks.cpp#L152
1. Open Safari with Develop Menu on
2. Deactivate Site Specific Hacks in the Develop Menu
3. Go to https://www.nhl.com/news/toronto-maple-leafs-morgan-rielly-demonstrates-proper-handwashing-technique/c-316213294?tid=281396148
4. Reach the video and do one tap
5. Video starts
6. Go to https://www.universityofgalway.ie/t4training/examples/embedded-videos/
7. Scroll down to reach the embedded Facebook video
8. Tap the video
9. Video Starts
Additional test
10. Go to https://www.facebook.com/stories/
11. ??
// https://bugs.webkit.org/show_bug.cgi?id=176402
// facebook.com https://bugs.webkit.org/show_bug.cgi?id=220834
// twitter.com https://bugs.webkit.org/show_bug.cgi?id=211932
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
10. Go to https://www.facebook.com/stories/
11. Working
Confirmed by Tim Nguyen
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/6720
Radar WebKit Bug Importer
<rdar://problem/102743471>
EWS
Committed 257451@main (a1197f89b028): <https://commits.webkit.org/257451@main>
Reviewed commits have been landed. Closing PR #6720 and removing active labels.