Bug 248195 – Allow `auto` and `normal` as container-name

• Component: CSS
• Status: RESOLVED FIXED

[Tim Nguyen (:ntim)]

https://wpt.fyi/results/css/css-contain/container-queries/container-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned&view=interop
https://wpt.fyi/results/css/css-contain/container-queries/at-container-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned&view=interop
https://wpt.fyi/results/css/css-contain/container-queries/container-name-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned&view=interop

[Radar WebKit Bug Importer]

<rdar://problem/102591474>

[Karl Dubost]

for my own education.

https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp#4654-4669
https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/Source/WebCore/css/ContainerQueryParser.cpp#54-74

Does that it needs another function to parse a specific case.

[Tim Nguyen (:ntim)]

(In reply to Karl Dubost from comment #2)
> for my own education.
> 
> https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/
> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp#4654-4669
> https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/
> Source/WebCore/css/ContainerQueryParser.cpp#54-74
> 
> Does that it needs another function to parse a specific case.

consumeContainerQuery takes care of consuming the at-rule.

consumeSingleContainerName takes care of consuming the name in the at-rule, but also in the `container-name` CSS property (see consumeContainerName).

[Karl Dubost]

Pull request: https://github.com/WebKit/WebKit/pull/6855

[EWS]

Committed 257236@main (f494a4e0965b): <https://commits.webkit.org/257236@main>

Reviewed commits have been landed. Closing PR #6855 and removing active labels.