Bug 248054
| Summary: | [Cocoa] Use AVCaptureDeviceDiscoverySession for camera discovery | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> |
| Component: | WebRTC | Assignee: | Eric Carlson <eric.carlson> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, moritz.zimmermann, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=250142 | ||
| Bug Depends on: | 248245 | ||
| Bug Blocks: | |||
Eric Carlson
Use AVCaptureDeviceDiscoverySession for camera discovery instead of AVCaptureDevice
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Carlson
rdar://101919809
Eric Carlson
Pull request: https://github.com/WebKit/WebKit/pull/6604
EWS
Committed 256849@main (460662e8590c): <https://commits.webkit.org/256849@main>
Reviewed commits have been landed. Closing PR #6604 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 248245
Eric Carlson
Pull request: https://github.com/WebKit/WebKit/pull/6872
EWS
Committed 257094@main (358c50c87d32): <https://commits.webkit.org/257094@main>
Reviewed commits have been landed. Closing PR #6872 and removing active labels.
Eric Carlson
*** Bug 247737 has been marked as a duplicate of this bug. ***
Mo
Could you verify if this change will allow access to other back cameras than just the default (wide-angle) on multi-camera iOS devices?
For example these devices:
- builtInDualWideCamera: https://developer.apple.com/documentation/avfoundation/avcapturedevice/devicetype/3377620-builtindualwidecamera
- https://developer.apple.com/documentation/avfoundation/avcapturedevice/devicetype/3377622-builtinultrawidecamera
Eric Carlson
(In reply to Mo from comment #8)
> Could you verify if this change will allow access to other back cameras than
> just the default (wide-angle) on multi-camera iOS devices?
>
> For example these devices:
> - builtInDualWideCamera:
> https://developer.apple.com/documentation/avfoundation/avcapturedevice/
> devicetype/3377620-builtindualwidecamera
> -
> https://developer.apple.com/documentation/avfoundation/avcapturedevice/
> devicetype/3377622-builtinultrawidecamera
This change exposes each of the physical cameras on a iOS device, which includes the ultra-wide angle camera on devices that have one.
It does not expose the built-in "dual wide" or "triple wide" virtual cameras that automatically switch between physical cameras when zoom factor, light level, and focus position allow.
Mo
Thank you very much, this is invaluable to us!
Would you know if support for iOS virtual cameras is planned for a future release?
Eric Carlson
(In reply to Mo from comment #10)
> Thank you very much, this is invaluable to us!
>
> Would you know if support for iOS virtual cameras is planned for a future
> release?
Yes, we are planning to investigate adding support for the virtual cameras.
Eric Carlson
(In reply to Eric Carlson from comment #11)
> (In reply to Mo from comment #10)
> > Thank you very much, this is invaluable to us!
> >
> > Would you know if support for iOS virtual cameras is planned for a future
> > release?
>
> Yes, we are planning to investigate adding support for the virtual cameras.
https://bugs.webkit.org/show_bug.cgi?id=250142
Ahmad Saleem
*** Bug 248106 has been marked as a duplicate of this bug. ***