Bug 248040
| Summary: | Smarter EWS Checks for Websites directory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, ap, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 248037 | ||
Ahmad Saleem
Hi Team,
I am raising another bug around "Websites" folder on GitHub Webkit directory, which also go through whole EWS checklist while it does not have directly any "WebCore" or "JSC" code and I don't think it needs to run all LayoutTests etc. (but again I can be wrong and there might be some rationale behind it) but I think we can be smarter and think of other ways on what tests to run etc.
- Evaluate on which integration / layout tests or other tests are relevant (If only enabled selectively - the EWS resources can be reused for other stuff)
PR as example - https://github.com/WebKit/WebKit/pull/6580
Doing all EWS LayoutTests (e.g., https://ews-build.webkit.org/#/builders/35/builds/31662)
Appreciate if something can discussed for following.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
The benefit is fairly small, as website changes are rare, but we should skip building/testing for these indeed.
Aakash, could you please advise where the paths for EWS to skip are in our code? I cannot find those any more.
Alexey Proskuryakov
Ah, CheckChangeRelevance in `Tools/CISupport/ews-build/steps.py looking at bug 248039
Radar WebKit Bug Importer
<rdar://problem/102649320>