Bug 248014
| Summary: | [WinCairo][WK1] Can't paint a font after painting very large font | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <fujii.hironori> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=246844 | ||
Fujii Hironori
[WinCairo][WK1] Can't paint a font after painting very large font
For example, fast/text/letter-spacing-produces-nan-width.html contains a very large font.
After load the test case, fast/text/simple-lines-float.html fails.
> python3.exe ./Tools/Scripts/run-webkit-tests --wincairo --debug -1 --no-retry-failures fast/text/letter-spacing-produces-nan-width.html fast/text/simple-lines-float.html --iterations=2 -v
> [1/4] fast/text/simple-lines-float.html passed
> [2/4] fast/text/letter-spacing-produces-nan-width.html passed
> [3/4] fast/text/simple-lines-float.html failed unexpectedly (reference mismatch maxDifference=255; totalPixels=1356)
> [4/4] fast/text/letter-spacing-produces-nan-width.html passed
The first test run of simple-lines-float.html passed, but failed in the second because it was after letter-spacing-produces-nan-width.html.
See also:
Bug 246844 – REGRESSION(cairo 1.17.6)[WinCairo] rendering glitches of twitter.com and yahoo.co.jp
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
PR: https://github.com/WebKitForWindows/WebKitRequirements/pull/101
Fujii Hironori
WinCairo WK1 is reporting the following flaky test failures. They seems to be caused by this bug.
Unexpected flakiness: image-only failures (5)
fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html [ ImageOnlyFailure Pass ]
fast/text/mobileasset-font.html [ ImageOnlyFailure Pass ]
fast/text/multi-code-unit-simple-path.html [ ImageOnlyFailure Pass ]
fast/text/simple-lines-float.html [ ImageOnlyFailure Pass ]
fast/text/text-underline-position-subscript.html [ ImageOnlyFailure Pass ]
Fujii Hironori
cairo issue ticket:
[windows] Don't leave cairo_font_face_t in an error state even after very large cairo_scaled_font_t creation (#607) · Issues · cairo / cairo · GitLab
https://gitlab.freedesktop.org/cairo/cairo/-/issues/607
Fujii Hironori
Fixed by https://github.com/WebKitForWindows/WebKitRequirements/releases/tag/v2022.12.22