Bug 24794

Summary:

Can enter auto scroll from a non-scrollable area

Product:

WebKit

Reporter:

Jon Honeycutt <jhoneycutt>

Component:

WebCore Misc.

Assignee:

Jessie Berlin <jberlin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, bweinstein

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Cancels the scroll if there are no vertical or horizonal scrollbars.	none
Does not instantiate an autoscroll when there are no scrollbars on the frame view.	none

Jon Honeycutt

Reported 2009-03-24 17:49:54 PDT

From discussion in bug #24722, it is possible to enter auto scroll when the area isn't scrollable. To reproduce, 1. Load http://google.com 2. Size the page until there are no scroll bars 3. Middle-click the page The auto scroll icon and cursor show, but the page is not scrollable.

Attachments
Cancels the scroll if there are no vertical or horizonal scrollbars. (2.11 KB, patch) 2009-06-22 20:33 PDT, Jessie Berlin	no flags	Details Formatted Diff Diff
Does not instantiate an autoscroll when there are no scrollbars on the frame view. (1.48 KB, patch) 2009-06-23 15:23 PDT, Jessie Berlin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2009-05-29 11:45:19 PDT

<rdar://problem/6933057>

Jessie Berlin

Comment 2 2009-06-22 20:33:25 PDT

Created attachment 31701 [details] Cancels the scroll if there are no vertical or horizonal scrollbars.

Jessie Berlin

Comment 3 2009-06-23 15:23:53 PDT

Created attachment 31744 [details] Does not instantiate an autoscroll when there are no scrollbars on the frame view. Assumes that there is no situation in which a frame does not have a frameview but the user should still be able to do an auto / pan scroll.

Brady Eidson

Comment 4 2009-06-23 15:26:22 PDT

Comment on attachment 31744 [details] Does not instantiate an autoscroll when there are no scrollbars on the frame view. Code change looks fine, but can we layout test this bad boy?

Brady Eidson

Comment 5 2009-06-23 15:27:09 PDT

Comment on attachment 31744 [details] Does not instantiate an autoscroll when there are no scrollbars on the frame view. Re-read precisely what this is about, I guess we can't quite test this yet. r+

Eric Seidel (no email)

Comment 6 2009-06-23 22:31:43 PDT

Is this patch supposed to be obsoleted? Or should it be landed?

Jessie Berlin

Comment 7 2009-06-24 06:46:32 PDT

(In reply to comment #6) > Is this patch supposed to be obsoleted? Or should it be landed? > Obsoleted. I did not take into account the case where there is a scrollable element inside of a frame view even then though frame view might not have scrollbars.

Eric Seidel (no email)

Comment 8 2009-06-24 18:50:06 PDT

Comment on attachment 31744 [details] Does not instantiate an autoscroll when there are no scrollbars on the frame view. Clearing review flag on obsoleted patch.

Brian Weinstein

Comment 9 2009-08-12 19:46:16 PDT

This bug was fixed as collateral damage with the fix of http://trac.webkit.org/changeset/47163.

Note You need to log in before you can comment on or make changes to this bug.