Bug 247911
| Summary: | Progress HTMLDocumentParser state on non-interrupted cases | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ap, beidson, cdumez, darin, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commit, I came across following:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=181346
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/e7be2359033b5a89111f70b799953e17421eeede/Source/WebCore/html/parser/HTMLDocumentParser.cpp#L446
Need to add:
DocumentParser::stopParsing();
___
It is still present to this date in Blink code:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/parser/html_document_parser.cc;l=992?q=Informs%20the%20rest%20of%20WebCore%20that%20parsing%20is%20really%20finished
Just want to raise it as potential merge due to commit message indicating that it changes "StoppingState" to "StoppedState" when parsing finished with any interruption.
___
Will tag few to comments and since it does not have any test case, I cannot confirm whether it regress any behavior or not
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
This change leads to massive failures across current test and have 70+ test crash on Webkit GTK and leading them out of memory. So it might be not as simple as it is and might need to have more thought given before hand.
I would let others to comment whether we should keep this open or we should close this with "RESOLVED LATER" or "RESOLVED WONTFIX". Thanks!
Radar WebKit Bug Importer
<rdar://problem/102586999>