Bug 247803

Summary: imported/w3c/web-platform-tests/inert/inert-node-is-unfocusable.html is failing
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, esprehn+autocc, ews-watchlist, kangil.han, mifenton, ntim, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239006
https://bugs.webkit.org/show_bug.cgi?id=251597
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2022-11-11 07:23:22 PST
On Mac WebKit2 only for some reason.
Comment 1 Antti Koivisto 2022-11-11 07:23:38 PST
https://bugs.webkit.org/show_bug.cgi?id=239006 fixes it for WK1
Comment 2 Tim Nguyen (:ntim) 2022-11-12 06:24:41 PST
on gtk wk2 as well.
Comment 3 Tim Nguyen (:ntim) 2022-11-12 08:53:47 PST Comment hidden (obsolete)
Comment 4 Tim Nguyen (:ntim) 2022-11-12 09:14:46 PST
(In reply to Tim Nguyen (:ntim) from comment #3)
> Looks like the failure is testing focusability on a date-time input, which I
> think are disabled on wk1, and different on iOS.

actually datetime is just an alias of text.

I think the issue here is that the siblings are not invalidated, only first child gets invalidated.
Comment 5 Antti Koivisto 2022-11-15 06:28:10 PST
Created attachment 463531 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2022-11-15 07:50:37 PST
<rdar://problem/102367494>
Comment 7 Antti Koivisto 2022-11-15 09:21:55 PST
Created attachment 463534 [details]
Patch
Comment 8 Antti Koivisto 2022-11-15 09:25:08 PST
Created attachment 463535 [details]
Patch
Comment 9 Antti Koivisto 2022-11-15 22:51:37 PST
Created attachment 463551 [details]
Patch
Comment 10 EWS 2022-11-17 07:17:39 PST
Committed 256782@main (aaa2528fde20): <https://commits.webkit.org/256782@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463551 [details].
Comment 11 Antoine Quint 2023-02-07 01:06:46 PST
This caused a regression: bug 251597.