Bug 247722 – Mismatched whitespace widths cause a wrong width of inline box

• Component: Layout and Rendering
• Status: RESOLVED INVALID

[Ahmad Saleem]

Hi Team,

This is another blink commit, which we can merge to fix few more edge cases of whitespace in inline box.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=195307

Webkit Source - https://github.com/WebKit/WebKit/blob/7a292520f6b12e8d4d9001d1480474b5c83cb0f8/Source/WebCore/rendering/RenderBlockFlow.cpp#L4099

Just wanted to create a bug report before trying.

Thanks!

[Karl Dubost]

Ahmad,

I am not sure there is anything to do here.
At least with regards to the test available in the chromium project.
The test as-is passes on Safari Technical Preview 157, Firefox Nightly 108, Chromium 109

[Ahmad Saleem]

(In reply to Karl Dubost from comment #1)
> Ahmad,
> 
> I am not sure there is anything to do here.
> At least with regards to the test available in the chromium project.
> The test as-is passes on Safari Technical Preview 157, Firefox Nightly 108,
> Chromium 109

This change led to failing following:

Test Case - https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/text/simple-line-layout-fallback-space-glyph.html

@Alan - we have following in expected file of above:

<!-- webkit-test-runner [ InlineFormattingContextIntegrationEnabled=false ] -->

Does this fix bug in legacy pipeline?

[Ahmad Saleem]

https://github.com/WebKit/WebKit/pull/6342

[Radar WebKit Bug Importer]

<rdar://problem/102456945>

[Ahmad Saleem]

As discussed with Alan on PR, it seems that it has some pre-requisite, which I will look into later but for time being I have closed my PR because the longer, it will be the more issue it might have and can have merge conflicts etc. So I am going to still investigate about what is the pre-requisite of this and then will try to land both in one go. Thanks!

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #0)
> Hi Team,
> 
> This is another blink commit, which we can merge to fix few more edge cases
> of whitespace in inline box.
> 
> Blink Commit -
> https://src.chromium.org/viewvc/blink?view=revision&revision=195307
> 
> Webkit Source -
> https://github.com/WebKit/WebKit/blob/
> 7a292520f6b12e8d4d9001d1480474b5c83cb0f8/Source/WebCore/rendering/
> RenderBlockFlow.cpp#L4099
> 
> Just wanted to create a bug report before trying.
> 
> Thanks!

This was regression fix from this change:

https://src.chromium.org/viewvc/blink?revision=192404&view=revision

^ I am not sure whether we have an issue about float conversion issue or not.

Link - https://github.com/WebKit/WebKit/blob/703f285930dc2b9c229d5630872d7bd52858171d/Source/WebCore/rendering/RenderText.cpp#L809

[alan]

Yeah, I don't think this applies to us (also IFC does not use this codepath for computing preferred widths anymore.)