Bug 247681

Summary:

Add out-of-flow objects under the inline in a continuation chain, when possible

Product:

WebKit

Reporter:

Ahmad Saleem <ahmad.saleem792>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

P2

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=284716

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
[fast-cq]Patch	none
[fast-cq]Patch	none
[fast-cq]Patch	none
[fast-cq]Patch	none

Ahmad Saleem

Reported 2022-11-09 08:33:18 PST

Hi Team, I came across another testcase failing in Safari 16.1 and STP 157 from the Blink commit. Failing Test Case - https://jsfiddle.net/37td5eur/show Commit - https://chromium.googlesource.com/chromium/src/+/77ec19ddefb32688cd18277ed7412531b536401a Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/675e4eb6f1e268b47b19b9a792c3c2b68336e19c/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp#L132 Just wanted to create a bug with failing test case. Thanks!

Attachments
Patch (4.14 KB, patch) 2025-01-25 20:48 PST, zalan	no flags	Details Formatted Diff Diff
Patch (5.83 KB, patch) 2025-01-26 06:45 PST, zalan	no flags	Details Formatted Diff Diff
Patch (5.83 KB, patch) 2025-01-27 06:46 PST, zalan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (5.83 KB, patch) 2025-01-27 08:11 PST, zalan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (5.83 KB, patch) 2025-01-27 13:38 PST, zalan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (5.83 KB, patch) 2025-01-27 18:44 PST, zalan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (5.83 KB, patch) 2025-01-28 07:34 PST, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-11-16 08:34:17 PST

<rdar://problem/102421379>

Ahmad Saleem

Comment 2 2022-12-01 12:36:36 PST

https://github.com/WebKit/WebKit/pull/6431 - I am not super sure on Line 153 on how to amend it.

Ahmad Saleem

Comment 3 2025-01-23 20:49:59 PST

Pull request: https://github.com/WebKit/WebKit/pull/39484

zalan

Comment 4 2025-01-25 20:48:22 PST

Created attachment 474010 [details] Patch

zalan

Comment 5 2025-01-26 06:45:48 PST

Created attachment 474013 [details] Patch

zalan

Comment 6 2025-01-27 06:46:25 PST

Created attachment 474023 [details] Patch

zalan

Comment 7 2025-01-27 08:11:53 PST

Created attachment 474024 [details] [fast-cq]Patch

zalan

Comment 8 2025-01-27 13:38:22 PST

Created attachment 474025 [details] [fast-cq]Patch

zalan

Comment 9 2025-01-27 18:44:02 PST

Created attachment 474033 [details] [fast-cq]Patch

zalan

Comment 10 2025-01-28 07:34:25 PST

Created attachment 474044 [details] [fast-cq]Patch

EWS

Comment 11 2025-01-28 07:48:31 PST

Committed 289451@main (1164dffe547d): <https://commits.webkit.org/289451@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 474044 [details].

Note You need to log in before you can comment on or make changes to this bug.