Text-indent is not supported on <option> elements

• Component: Forms
• Status: RESOLVED FIXED

[Ada Chan]

Text-indent is not supported on option elements.

For example:
<select>
  <option>no text-indent</option>
  <option style="text-indent: 100px;">100px text-indent</option>
</select>

The second option should be much wider due to the text-indent, causing the select to be wider also.

[Ada Chan]

Created attachment 28858 [details]
Patch

Comment on attachment 28858 [details]
Patch

Setting the review flag

Comment on attachment 28858 [details]
Patch

I think you can make the PopupMenuStyle changes in all platform, even if only Windows uses the extra members now. For the RenderMenuList.cpp change, the problem is that not all Windows platform ports use PopupMenuWin.cpp and themeWin.css. Perhaps it should be a RenderTheme decision whether to support text-indent. Then RenderMenuList can as the theme if it should apply the indent to the width, and PopupMenuWin could do the same.

(In reply to comment #3)
> Then RenderMenuList can as the theme

s/as/ask/

[Ada Chan]

Created attachment 28872 [details]
Second try.

Added RenderTheme::popupOptionSupportsTextIndent().

[Adele Peterson]

Comment on attachment 28872 [details]
Second try.

I think you have extra spacing on the last line here.

> +            maxOptionWidth = max(maxOptionWidth, optionWidth);
> +        } else if (!text.isEmpty())
> +                maxOptionWidth = max(maxOptionWidth, style()->font().floatWidth(text));
>      }

Looks good!  r=me.

[Ada Chan]

Fixed in r41923.