Bug 24743

Summary: REGRESSION (r41840): Incorrect hit testing at hsbccreditcard.com
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Major CC: rboucher, simon.fraser, zwarich
Priority: P1 Keywords: HasReduction, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
URL: https://www.hsbccreditcard.com/ecare/logoff_redirect
Attachments:
Description Flags
Reduction
none
Patch, testcase, changelog
mitz: review+
Patch, testcase, changelog mitz: review+

Description mitz 2009-03-21 17:19:44 PDT
At hsbccreditcard.com, everything below the logo does not respond to clicking and control-clicking.
Comment 1 Cameron Zwarich (cpst) 2009-03-21 21:07:31 PDT
I'll try to reduce this, but I won't be the one to fix it.
Comment 2 Cameron Zwarich (cpst) 2009-03-21 21:11:43 PDT
This regressed between the r41760 and r41844 nightlies. There are a few changes to hit testing code in that range.
Comment 3 Cameron Zwarich (cpst) 2009-03-21 22:17:24 PDT
Created attachment 28830 [details]
Reduction

Here's a really simple reduction. I'll bisect local builds to find the point of failure.
Comment 4 Cameron Zwarich (cpst) 2009-03-21 22:49:30 PDT
This regressed in r41840:

http://trac.webkit.org/changeset/41840

I am unassigning this. One of the hit testing wizards should fix this. ;-)
Comment 5 Simon Fraser (smfr) 2009-03-22 10:13:14 PDT
Hm, r41840 should not have affected non-3d hit testing.
Comment 6 Simon Fraser (smfr) 2009-03-22 11:32:48 PDT
Created attachment 28834 [details]
Patch, testcase, changelog
Comment 7 mitz 2009-03-22 11:36:24 PDT
Comment on attachment 28834 [details]
Patch, testcase, changelog

> +        * fast/layers/zindex-hit-test.html: Added.

Please generate results, add them to the change log and check them in.

> +  #container {
> +  /*    position: absolute;*/
> +  }

You can just remove this rule.

> \ No newline at end of file

Please add a newline.

r=me
Comment 8 Simon Fraser (smfr) 2009-03-22 11:36:47 PDT
Created attachment 28835 [details]
Patch, testcase, changelog

Add test expected file.
Comment 9 mitz 2009-03-22 11:38:27 PDT
Comment on attachment 28835 [details]
Patch, testcase, changelog

The rest of my previous comments still apply to this patch.
r=me
Comment 10 Simon Fraser (smfr) 2009-03-22 11:43:40 PDT
http://trac.webkit.org/changeset/41900
Comment 11 Cameron Zwarich (cpst) 2009-03-23 19:47:47 PDT
*** Bug 24766 has been marked as a duplicate of this bug. ***