Bug 24742

Summary: CSS tokenizer allows color in 6 hex digit notation to be followed by the next token without separation
Product: WebKit Reporter: mitz
Component: CSSAssignee: Yuzo Fujishima <yuzo>
Status: RESOLVED FIXED    
Severity: Minor CC: bdakin, commit-queue, emacemac7, yuzo, zwarich
Priority: P3 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
URL: data:text/html,<div style="border-top: solid %230077ff9px;"></div>
Attachments:
Description Flags
Fix for Bug 24742 - CSS tokenizer allows color in 6 hex digit notation to be followed by the next token without separation darin: review+, commit-queue: commit-queue-

mitz
Reported 2009-03-21 11:50:34 PDT
The CSS in the URL is parsed as "border-top: solid #0077ff 9px;" despite the missing space after #0077ff. I think #0077ff9px should be treated as one token and rejected.
Attachments
Fix for Bug 24742 - CSS tokenizer allows color in 6 hex digit notation to be followed by the next token without separation (7.54 KB, patch)
2010-05-13 06:16 PDT, Yuzo Fujishima 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2009-03-21 11:51:16 PDT
<rdar://problem/6707824>
Cameron Zwarich (cpst)
Comment 2 2009-03-22 02:18:00 PDT
This seems to be the case from the spec: http://www.w3.org/TR/CSS21/grammar.html The lexical scanner given there will take the "#0077ff9px" and give a single HASH token, because it eats the '#' and then matches a name, which is "0077ff9px". Flex has "longest match" semantics, so this seems to be the correct interpretation. I am sure you knew this, just filling it in for context. Are there any possibility compatibility issues with this change?
mitz
Comment 3 2009-03-22 10:07:12 PDT
(In reply to comment #2) > This seems to be the case from the spec: I am not sure I understand. Are you saying that WebKit behaves correctly? > Are there any possibility compatibility issues with this change? Firefox and Opera don't behave like WebKit.
Cameron Zwarich (cpst)
Comment 4 2009-03-22 14:09:43 PDT
(In reply to comment #3) > I am not sure I understand. Are you saying that WebKit behaves correctly? No, I was just trying to point out how the spec agrees with you.
Yuzo Fujishima
Comment 5 2010-05-13 06:16:57 PDT
Created attachment 55966 [details] Fix for Bug 24742 - CSS tokenizer allows color in 6 hex digit notation to be followed by the next token without separation
Yuzo Fujishima
Comment 6 2010-05-19 01:53:27 PDT
Ping?
WebKit Commit Bot
Comment 7 2010-09-02 18:00:44 PDT
Comment on attachment 55966 [details] Fix for Bug 24742 - CSS tokenizer allows color in 6 hex digit notation to be followed by the next token without separation Rejecting patch 55966 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20909 test cases. svg/custom/invalid-fill-hex.svg -> failed Exiting early after 1 failures. 18102 tests run. 376.27s total testing time 18101 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 26 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3944067
Yuzo Fujishima
Comment 8 2010-09-02 18:17:03 PDT
Eric, Sorry, I forgot to mention here that this patch depends on a SVG fix. https://lists.webkit.org/pipermail/webkit-dev/2010-June/013358.html Having heard no updates from Nikolas or Dirk, I think we should just fix svg/custom/invalid-fill-hex.svg. That is, to remove 'stroke="#0"' from: LayoutTests/svg/custom/invalid-fill-hex.svg <rect width="100" height="100" fill="#ff" stroke="#0"/> What do you think?
Yuzo Fujishima
Comment 9 2010-09-09 20:33:18 PDT
Committed r67158: <http://trac.webkit.org/changeset/67158>
Note You need to log in before you can comment on or make changes to this bug.