Bug 247369
| Summary: | Typo error in RenderLayerCompositor::destroyRootLayer() for Horizontal Scrollbar | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commits, I came across following commit, which seems to indicate a typo or copy/paste error in the code:
Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=194036
GitHub Code - https://github.com/WebKit/WebKit/blob/3be97089de542dc412c3155045912fe6b6b70a10/Source/WebCore/rendering/RenderLayerCompositor.cpp#L4299
Why it is typo because, this is for "m_layerForHorizontalScrollbar" while we are discussing about "verticalScrollbar" and it is same as Line 4307, which is for verticalScrollbar in actual.
Just creating this bug to fix the issue.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 256247@main (1ad126f47e2a): <https://commits.webkit.org/256247@main>
Reviewed commits have been landed. Closing PR #6039 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/101881625>