Bug 247317

Summary: RenderElement::updateFillImages should take pointer arguments like other similar functions
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antti Koivisto
Reported 2022-11-01 07:05:16 PDT
Like updateImage etc
Attachments
Patch (5.21 KB, patch)
2022-11-01 07:12 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-11-01 07:09:19 PDT
rdar://100273147
Antti Koivisto
Comment 2 2022-11-01 07:12:01 PDT
Created attachment 463342 [details] Patch
EWS
Comment 3 2022-11-01 10:45:18 PDT
Found 3 new test failures: imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-unsafe-none.https.html, imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html, storage/indexeddb/modern/abort-objectstore-info-private.html
EWS
Comment 4 2022-11-01 14:53:03 PDT
Found 30 new test failures: compositing/geometry/rtl-overflow-scroll.html, css1/pseudo/anchor.html, fast/forms/multiple-form-submission-protection-mouse.html, fast/forms/submit-to-blank-multiple-times.html, http/tests/media/fairplay/fps-hls-update-reject.html, http/tests/navigation/subframe-pagehide-handler-starts-load2.html, http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html, http/tests/resourceLoadStatistics/third-party-cookie-blocking.html, http/tests/security/contentSecurityPolicy/worker-importscripts-blocked.html, http/wpt/cache-storage/cache-quota-after-restart.any.html ...
EWS
Comment 5 2022-11-01 23:30:25 PDT
Committed 256215@main (091a04e55c80): <https://commits.webkit.org/256215@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463342 [details].
Note You need to log in before you can comment on or make changes to this bug.