Bug 247172
Summary: | Fix default angle cases from at-font-face-descriptors.html | ||
---|---|---|---|
Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://github.com/web-platform-tests/wpt/pull/36707 | ||
Bug Depends on: | |||
Bug Blocks: | 246579 |
Tim Nguyen (:ntim)
The default angle is now 14deg, not 20deg, but even then, I do not think we should treat the default angle specially in this case, given that it changed. We lose information by serializing to the shorter form (did the author intend to mean 20deg or the current default angle?). For clarity, always putting the angle is better.
See: https://github.com/w3c/csswg-drafts/issues/2295
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101666575>
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/5890
Tim Nguyen (:ntim)
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/36707
EWS
Committed 256098@main (3e8ac0a21f30): <https://commits.webkit.org/256098@main>
Reviewed commits have been landed. Closing PR #5890 and removing active labels.