| Summary: | [Qt] Many WebActions don't accurately track when they are applicable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Erik L. Bunce <elbunce> | ||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 28784 [details]
Fix to make WebActions more accurately track their underlying commands
Created attachment 28785 [details]
Fix to make WebActions more accurately track their underlying commands
Fixed WebAction documentation per Ariya's request.
|
The enablement of many WebActions doesn't accurately track when they are applicable. * Many commands that are implemented by using an Editor Command are tracking Editor can{EditRichly,Cut,Copy,Paste}(), which don't accurately reflect the availability of the underlying commands. * The setTextDirection{} actions that may be applicable to several non-rich editing context have their enablement controlled by the Editor canEditRichly(). I propose using the underlying Editor Commands concept and logic for determining when WebActions are available where applicable. I further propose that the setTextDirection() actions should be available when canEdit() is true. I noticed these problems while working on my QtHtmlEditor (found in https://bugs.webkit.org/attachment.cgi?id=28745).