Bug 247024

Summary: [MSVC] Suppress warning C4805: 'operation' : unsafe mix of type 'type' and type 'type' in operation
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: New BugsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, basuke, dino, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch
none
[fast-cq] Patch none

Fujii Hironori
Reported 2022-10-25 13:45:29 PDT
WinCairo EWS is failing to compile due to the following warning. C:\BW\WinCairo-EWS\build\Source\WebCore\platform\graphics\angle\ANGLEUtilities.cpp(155): error C2220: the following warning is treated as an error C:\BW\WinCairo-EWS\build\Source\WebCore\platform\graphics\angle\ANGLEUtilities.cpp(155): warning C4805: '==': unsafe mix of type 'GLboolean' and type 'bool' in operation
Attachments
[fast-cq] Patch (1.28 KB, patch)
2022-10-25 13:47 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (1.65 KB, patch)
2022-10-25 14:06 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-10-25 13:47:44 PDT
Created attachment 463242 [details] [fast-cq] Patch
Fujii Hironori
Comment 2 2022-10-25 13:56:08 PDT
Other ports don't complain. I think we should suppress warning C4805.
Fujii Hironori
Comment 3 2022-10-25 14:06:51 PDT
Created attachment 463243 [details] [fast-cq] Patch
EWS
Comment 4 2022-10-25 14:15:43 PDT
Committed 255981@main (fbeb80ee96c9): <https://commits.webkit.org/255981@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463243 [details].
Radar WebKit Bug Importer
Comment 5 2022-10-25 14:16:19 PDT
<rdar://problem/101561022>
Note You need to log in before you can comment on or make changes to this bug.