| Summary: | REGRESSION: Java Applets broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Amit Joshi <amit> | ||||
| Component: | Plug-ins | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | amit, ap, finnur.webkit, sam | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| URL: | http://java.sun.com/applets/jdk/1.4/demo/applets/ArcTest/example1.html | ||||||
| Attachments: |
|
||||||
Amit. Isn't that by design? http://java.sun.com/j2se/1.4.2/docs/guide/misc/applet.html Quote: CODEBASE = codebaseURL This OPTIONAL attribute specifies the base URL of the applet--the directory that contains the applet's code. If this attribute is not specified, then the document's URL is used. Also reported against Chromium, see http://code.google.com/p/chromium/issues/detail?id=8936 Created attachment 28871 [details]
patch
Comment on attachment 28871 [details]
patch
r=me
+String KURL::baseAsString() const
+{
+ return m_string.left(m_pathAfterLastSlash);
+}
It's quite confusing that KURL now uses "base" in different meanings. It's especially so when comparing to CFURLRef/NSURL, which remember the base URL they were created with, and have accessors for it.
(In reply to comment #7) > +String KURL::baseAsString() const > +{ > + return m_string.left(m_pathAfterLastSlash); > +} > > It's quite confusing that KURL now uses "base" in different meanings. It's > especially so when comparing to CFURLRef/NSURL, which remember the base URL > they were created with, and have accessors for it. > Good point. Do you have a suggestion for a better name? Maybe parentDirectoryPath()? This will also make it clearer that the method only works properly for hierarchical URL schemes. |
Java applets that do not specify 'codebase' in the embed/object tag do not work. This is due to a recent Revision 41568. If codebase is not specified, then HTMLAppletElement::createRenderer sets it using args.set("codeBase", document()->baseURL().string()); This sets it to the page url instead of it's base path.