Bug 246905

Summary: AX: AccessibilityNodeObject::ariaLabeledByText appends to a Vector that it never uses
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tyler Wilcock
Reported 2022-10-22 12:19:56 PDT
In this commit: https://github.com/WebKit/WebKit/commit/f8283a7eece23958929380c652cebb7e7d302244 (Removed unused textElements member from AccessibilityText structure) We stopped using the local `axElements` Vector in AccessibilityNodeObject::ariaLabeledByText, but still build it for no reason.
Attachments
Patch (1.97 KB, patch)
2022-10-22 12:21 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-10-22 12:20:08 PDT
<rdar://problem/101462816>
Tyler Wilcock
Comment 2 2022-10-22 12:21:38 PDT
Created attachment 463169 [details] Patch
EWS
Comment 3 2022-10-22 20:47:56 PDT
Committed 255890@main (e081fcf0fbd4): <https://commits.webkit.org/255890@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463169 [details].
Note You need to log in before you can comment on or make changes to this bug.