Bug 246845
| Summary: | [WebDriver] Update w3c tests with get_computed_role and get_computed_label fixes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, cgarcia, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=246814 https://bugs.webkit.org/show_bug.cgi?id=246813 |
||
Lauro Moura
When fixing bug246813, two tests were failing due to issues in the test cases themselves, fixed upstream in [1] in August 2022.
It'll be a reasonably big bump (last import was from December 2021 and the diff contains around 158 commits) and some extra work will be needed in the test executors. For example, it'll require changes in webkitpy's webdriver executor due to the removal of `WebDriverServer` in [2].
[1] https://github.com/web-platform-tests/wpt/commit/76cc414789e2b16ab90a7c6a0c98cfc6f2eb39f4
[2] https://github.com/web-platform-tests/wpt/commit/51c8ca12b4cbc7acd29e90038211d6c516ceb09c
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101664213>
Lauro Moura
WIP patch importing https://github.com/web-platform-tests/wpt/commit/76cc414789e2b16ab90a7c6a0c98cfc6f2eb39f4 in https://github.com/lauromoura/WebKit/tree/wip-bug246845-webdriver-bump
Not sure if I was doing the right approach to replace WebDriverServer.
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/6244
EWS
Committed 256638@main (48b4b1609fe7): <https://commits.webkit.org/256638@main>
Reviewed commits have been landed. Closing PR #6244 and removing active labels.